b3nw/gitea-mcp
Archived
1
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Duplicated logic for EditMilestoneOption in milestone operations #8

New Issue
Open
opened 2025-07-11 15:35:20 -05:00 by b3nw · 0 comments
b3nw commented 2025-07-11 15:35:20 -05:00
Owner
Copy Link

In operation/milestone/milestone.go, the logic for populating the gitea_sdk.EditMilestoneOption struct is duplicated in EditMilestoneFn (for editing by ID) and EditMilestoneByNameFn (for editing by name).

Recommendation:
To improve maintainability and reduce redundancy, this logic should be extracted into a shared helper function.

In `operation/milestone/milestone.go`, the logic for populating the `gitea_sdk.EditMilestoneOption` struct is duplicated in `EditMilestoneFn` (for editing by ID) and `EditMilestoneByNameFn` (for editing by name). **Recommendation:** To improve maintainability and reduce redundancy, this logic should be extracted into a shared helper function.
b3nw added the enhancementmilestone-management labels 2025-07-11 15:45:28 -05:00
This repo is archived. You cannot comment on issues.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 enhancement
New feature or request
 feature
New feature implementation
 label-management
Related to label functionality
 milestone-management
Related to milestone functionality
No Label enhancement milestone-management
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
b3nw
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: b3nw/gitea-mcp#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?