mirror of
https://github.com/b3nw/nginx-proxy-manager-mcp.git
synced 2026-06-09 23:09:40 -05:00
b3nw
ddaf4190f9
- Introduced ServerRegistry to manage multiple NPM instances - Added support for NPM_SERVERS JSON environment variable - Updated all tools to support optional 'server' targeting - Implemented clone_proxy_host, sync_access_lists, and sync_certificates tools - Transitioned get_proxy_host_logs to API-based retrieval with local fallback - Added comprehensive test suite for multi-server management and sync operations Co-authored-by: claw-io <agent@ben.io>
130 lines
4.7 KiB
Python
130 lines
4.7 KiB
Python
"""Tests for configuration handling."""
|
|
|
|
import pytest
|
|
from pydantic_settings.exceptions import SettingsError
|
|
|
|
from npm_mcp.config import DEFAULT_PROXY_SETTINGS, Settings
|
|
|
|
|
|
class TestProxyDefaults:
|
|
"""Test NPM_PROXY_DEFAULTS parsing and merging."""
|
|
|
|
def test_default_proxy_settings(self):
|
|
"""Test that default settings are correct."""
|
|
settings = Settings(identity="test", secret="test")
|
|
defaults = settings.get_proxy_defaults()
|
|
|
|
assert defaults["forward_scheme"] == "http"
|
|
assert defaults["certificate_id"] == 0
|
|
assert defaults["ssl_forced"] is True
|
|
assert defaults["block_exploits"] is True
|
|
assert defaults["allow_websocket_upgrade"] is True
|
|
assert defaults["access_list_id"] == 0
|
|
assert defaults["advanced_config"] == ""
|
|
|
|
def test_proxy_defaults_json_parsing(self, monkeypatch):
|
|
"""Test parsing JSON string from environment variable."""
|
|
monkeypatch.setenv("NPM_IDENTITY", "test")
|
|
monkeypatch.setenv("NPM_SECRET", "test")
|
|
monkeypatch.setenv("NPM_PROXY_DEFAULTS", '{"certificate_id": 24, "ssl_forced": false}')
|
|
|
|
settings = Settings()
|
|
defaults = settings.get_proxy_defaults()
|
|
|
|
# Overridden values
|
|
assert defaults["certificate_id"] == 24
|
|
assert defaults["ssl_forced"] is False
|
|
|
|
# Default values preserved
|
|
assert defaults["forward_scheme"] == "http"
|
|
assert defaults["block_exploits"] is True
|
|
|
|
def test_proxy_defaults_dict_passthrough(self):
|
|
"""Test that dict values pass through correctly."""
|
|
settings = Settings(
|
|
identity="test",
|
|
secret="test",
|
|
proxy_defaults={"certificate_id": 18, "access_list_id": 5},
|
|
)
|
|
defaults = settings.get_proxy_defaults()
|
|
|
|
assert defaults["certificate_id"] == 18
|
|
assert defaults["access_list_id"] == 5
|
|
|
|
def test_proxy_defaults_empty_env_raises(self, monkeypatch):
|
|
"""Test that empty string env var raises SettingsError."""
|
|
monkeypatch.setenv("NPM_IDENTITY", "test")
|
|
monkeypatch.setenv("NPM_SECRET", "test")
|
|
monkeypatch.setenv("NPM_PROXY_DEFAULTS", "")
|
|
|
|
# pydantic-settings tries to JSON decode empty string and fails
|
|
with pytest.raises(SettingsError):
|
|
Settings()
|
|
|
|
def test_proxy_defaults_invalid_json_raises(self, monkeypatch):
|
|
"""Test that invalid JSON raises SettingsError."""
|
|
monkeypatch.setenv("NPM_IDENTITY", "test")
|
|
monkeypatch.setenv("NPM_SECRET", "test")
|
|
monkeypatch.setenv("NPM_PROXY_DEFAULTS", "{not valid json}")
|
|
|
|
# pydantic-settings tries to JSON decode and fails
|
|
with pytest.raises(SettingsError):
|
|
Settings()
|
|
|
|
def test_proxy_defaults_merges_not_replaces(self):
|
|
"""Test that user defaults merge with base defaults."""
|
|
settings = Settings(
|
|
identity="test",
|
|
secret="test",
|
|
proxy_defaults={"certificate_id": 24},
|
|
)
|
|
defaults = settings.get_proxy_defaults()
|
|
|
|
# All keys should be present
|
|
assert set(defaults.keys()) == set(DEFAULT_PROXY_SETTINGS.keys())
|
|
|
|
# User value applied
|
|
assert defaults["certificate_id"] == 24
|
|
|
|
# Other defaults preserved
|
|
assert defaults["ssl_forced"] is True
|
|
assert defaults["block_exploits"] is True
|
|
|
|
|
|
class TestMultiServerConfig:
|
|
"""Test multi-server configuration parsing."""
|
|
|
|
def test_servers_empty_by_default(self):
|
|
"""Test that servers is empty by default."""
|
|
s = Settings(identity="test", secret="test")
|
|
assert s.servers == []
|
|
assert s.default_server is None
|
|
|
|
def test_servers_json_parsing(self, monkeypatch):
|
|
"""Test parsing servers JSON list from environment variable."""
|
|
monkeypatch.setenv("NPM_IDENTITY", "test")
|
|
monkeypatch.setenv("NPM_SECRET", "test")
|
|
monkeypatch.setenv(
|
|
"NPM_SERVERS",
|
|
'[{"name": "prod", "url": "http://prod:81/api", "identity": "p", "secret": "ps"}, '
|
|
'{"name": "dev", "url": "http://dev:81/api", "identity": "d", "secret": "ds"}]'
|
|
)
|
|
monkeypatch.setenv("NPM_DEFAULT_SERVER", "prod")
|
|
|
|
s = Settings()
|
|
assert len(s.servers) == 2
|
|
assert s.servers[0]["name"] == "prod"
|
|
assert s.servers[0]["url"] == "http://prod:81/api"
|
|
assert s.servers[1]["name"] == "dev"
|
|
assert s.default_server == "prod"
|
|
|
|
def test_servers_invalid_json_raises(self, monkeypatch):
|
|
"""Test that invalid servers JSON raises SettingsError."""
|
|
monkeypatch.setenv("NPM_IDENTITY", "test")
|
|
monkeypatch.setenv("NPM_SECRET", "test")
|
|
monkeypatch.setenv("NPM_SERVERS", "{not valid}")
|
|
|
|
with pytest.raises(SettingsError):
|
|
Settings()
|
|
|